chore: custom resume for awaitables #42
Open
+2,756
−397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An automated preview of the documentation is available at https://42.capy.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2025-12-29 07:31:49 UTC |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #42 +/- ##
===========================================
+ Coverage 74.40% 75.59% +1.19%
===========================================
Files 23 28 +5
Lines 1293 1676 +383
===========================================
+ Hits 962 1267 +305
- Misses 331 409 +78
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
GCOVR code coverage report https://42.capy.prtest3.cppalliance.org/gcovr/index.html Build time: 2025-12-29 07:36:46 UTC |
- Replace shared_ptr with function pointer vtable + void* pair - executor now references execution context without ownership - Add thread_pool class declaration with executor interface - Update tests to use stack-allocated execution contexts - Matches Asio/P2300 pattern: context owns resources, executor is lightweight handle
- Add executor::access struct as friend gateway for contexts - Execution contexts friend access and keep allocate/deallocate/submit private - Update ops_for to call through access:: methods - Add get_executor() to thread_pool - Expand documentation with execution context implementation guide - Document work lifecycle and ownership transfer semantics - Update tests to use friend pattern
- Add size and align public members to executor::work - factory::commit() sets these before submission - Execution contexts use w->size and w->align when deallocating - Implement thread_pool with worker threads and work queue - Add comprehensive thread_pool tests
- work_arena: fixed-size buffer allocating high-to-low - Tracks allocation count, deallocate just decrements - work_arena_pool: manages multiple arenas dynamically - Geometric size growth, prunes excess empty arenas - Settles to ~2 arenas under steady-state load
- Reorder declarations: dtor before ctor - Add Javadoc to work_arena and work_arena_pool accessors - Fix minor formatting (stray whitespace)
- Remove friend, allocate, deallocate, submit from thread_pool - Bind executor to impl instead of thread_pool - Keep execution context as implementation detail
- Rename class work_arena_pool -> work_allocator - Make work_arena a nested type work_allocator::arena - Rename files work_arena.hpp/cpp -> work_allocator.hpp/cpp - Move arena definition out-of-line with forward declaration
- Replace auto lambda parameters with explicit types - Use system::result instead of boost::system::result
- Replace auto lambda parameters with explicit types in tests - Fix unused lambda capture warning in async_post (C++20)
- Remove size, align, next members from executor::work - Execution contexts now prepend a header to track allocation metadata - Update thread_pool::impl to use header pattern - Update test executors to use header pattern - executor::work is now minimal (just vtable pointer)
Ensures strict C++ standards conformance for pointer comparisons across different allocations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.