Fix control window overwrite issue: #303
Open
+103
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow sat-pref-rig and sat-pref-rot to access nbook as an extern variable - added functions conf_open_in_rigctrlwin and conf_open_in_rotctrlwin - added dailog boxes displaying when the error occurs - prevent user from editing rig/rot configurations when a control window is open This is in response to an issue where, if the user opens an editor while the respective control window is also open, then the call to the radio/rotor_conf_save function when the control window is closed overwrites changes made in the editor.
spsvihla
force-pushed
the
fix-ctrl-conf-overwrite
branch
from
1531e6c to
1b79e0b
Compare
Owner
|
I don't understand how this situation can occur. A module configuration window cannot be opened if the radio or rotator controller of that module is open. The other way around, if the module configuration window is open, the radio and rotator controllers can not be opened because the configuration window is modal and the module menu cannot be activated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to an issue where, if the user opens an editor while the respective control window is also open, then the call to the radio/rotor_conf_save function when the control window is closed overwrites changes made in the editor.