-
-
Notifications
You must be signed in to change notification settings - Fork 329
UI: Fix incorrect cursor style on Filter options and RESET button (#436) #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
UI: Fix incorrect cursor style on Filter options and RESET button (#436) #447
Conversation
vbakke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing this out, @Biswas-Samrat.
Can you add the pointer hand to the filter chips in the Overview page as well? So that all pages stays consistent?
Also, when we are tiding CSS, can you base on the defined CSS variables (such as --primary-color)? That way we slowly get rid of all the hard coded color codes all over the place :)
|
Hi @vbakke, I have updated the PR to include cursor: pointer for the filter chips on the Overview page. |
vbakke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Biswas-Samrat. Please also update the colour, and sign the submissions. :)
| } | ||
|
|
||
| .reset-button:hover { | ||
| background-color: #4caf50; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a number of "green colours" scattered around the CSS, but let's try to reduce the numbers. Please base the colours on the var()s defined in custom-theme.scss, whenever possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vbakke Done thate
Fixes a UI issue where interactive filter elements and the RESET button were using the default cursor. They now correctly display the pointer cursor on hover.
Closes #436