WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

chore(crypto): CRP-2781 Make KeyId from MEGaPublicKey conversion infalliable #8180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
randombit merged 9 commits into from
Jan 5, 2026
Merged

chore(crypto): CRP-2781 Make KeyId from MEGaPublicKey conversion infalliable #8180

randombit merged 9 commits into from
Jan 5, 2026

Conversation

@randombit
Copy link
Contributor

@randombit randombit commented Dec 22, 2025 •
edited
Loading

This previously could panic as, at one point in the past, there were some possible MEGa curve types which did not have an associated AlgorithmId value. Since they are available now, we can make the conversion infallible.

@github-actions github-actions bot added the chore label Dec 22, 2025
@randombit randombit marked this pull request as ready for review January 5, 2026 14:17
@randombit randombit requested a review from a team as a code owner January 5, 2026 14:17
fspreiss
fspreiss approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@fspreiss fspreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @randombit!

@randombit randombit enabled auto-merge January 5, 2026 16:51
@randombit randombit added this pull request to the merge queue Jan 5, 2026
Merged via the queue into master with commit 3eba24c Jan 5, 2026
65 of 66 checks passed
@randombit randombit deleted the jack/crp-2781 branch January 5, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fspreiss fspreiss fspreiss approved these changes

Assignees

No one assigned

Labels

chore @consensus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@randombit @fspreiss