sockets: ConfigureTransport: prevent idle connections leaking FDs #134
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -27,6 +27,14 @@ var ErrProtocolNotAvailable = errors.New("protocol not available") | |||||
| // make sure you do it _after_ any subsequent calls to ConfigureTransport is made against the same | ||||||
| // [http.Transport]. | ||||||
| func ConfigureTransport(tr *http.Transport, proto, addr string) error { | ||||||
| if tr.MaxIdleConns == 0 { | ||||||
| // prevent long-lived processes from leaking connections | ||||||
| // due to idle connections not being released. | ||||||
| // | ||||||
| // TODO: see if we can also address this from the server side; see: https://github.com/moby/moby/issues/45539 | ||||||
| tr.MaxIdleConns = 6 | ||||||
| tr.IdleConnTimeout = 30 * time.Second | ||||||
|
There was a problem hiding this comment. [nitpick] Consider extracting the timeout value '30 * time.Second' into a named constant to allow for easier configuration and clearer intent.
Suggested change
Member
Author
There was a problem hiding this comment. I'll keep this for now; keeping all of these together may more clearly indicate the slightly "ad-hoc" nature of this. |
||||||
| } | ||||||
| switch proto { | ||||||
| case "unix": | ||||||
| return configureUnixTransport(tr, proto, addr) | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider extracting the magic number '6' into a named constant for improved clarity and maintainability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll keep this for now; keeping all of these together may more clearly indicate the slightly "ad-hoc" nature of this.