nat: cleanup, optimize, and improve errors #144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nat: improve some assertions
nat: add parsePortNumber utility
Add a utility for parsing and validating port-numbers to reduce
repetition and improve errors.
nat: ParsePortRange, ParsePortRangeToInt: reimplement with parsePortNumber
which we cast to the right type in ParsePortRange.
nat: NewPort: reimplement with parsePortNumber
nat: ParsePortSpec: reimplement with parsePortNumber
nat: make Port methods more self-contained
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)