sockets: implement WithAdditionalUsersAndGroups for windows #149
+206
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement a WithAdditionalUsersAndGroups (windows daemon allows specifying multiple additional users and groups for named pipes and unix-sockets). - Implement a WithBasePermissions() option for windows - Implement NewUnixSocket that accepts (optional) additional users and groups. Signed-off-by: Sebastiaan van Stijn <[email protected]> Signed-off-by: Craig Gumbley <[email protected]>
Prior to this change we were setting `OWNER_SECURITY_INFORMATION` along with `DACL_SECURITY_INFORMATION`. Since we are not touching the owner, I don't think we need to set this. Furthermore, the test was failing because the DACL was actually protected (`D:P(A;;GA;;;BA)(A;;GA;;;SY)`) and we need to tell the API about it. Setting `PROTECTED_DACL_SECURITY_INFORMATION` fixes the issue and allows socket creation with the required security descriptor. Signed-off-by: Craig Gumbley <[email protected]>
chelnak
force-pushed
the
windows_unix_socket_permissions
branch
from
acb350a to
536df70
Compare
vvoland
approved these changes
Dec 1, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixes socket creation on Windows by using
PROTECTED_DACL_SECURITY_INFORMATIONwhen setting the security descriptor.- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)