Report default floats with float type for MySQL

[PaulCombal]

Q	A
Type	bug/improvement
Fixed issues	doctrine/migrations#1542

Summary

For MySQL databases, the default value is always reported as being a string, which causes doctrine/migrations to be confused sometimes.

It's my first time contributing to Doctrine please be free to request edits.

[derrabus]

Thank you for the PR. Please always add a test that reproduces the issue you're attempting to solve.

[morozov]

For MySQL databases, the default value is always reported as being a string, which causes doctrine/migrations to be confused sometimes.

I would attempt to fix that instead. Database drivers represent some numbers as strings for a reason.

Using floats for any kind of logic that involves comparison may just exacerbate the problem. Also, if we want to make such a change, it should be implemented and tested consistently across all supported platforms, not only MySQL.

[PaulCombal]

What you're saying is that I should be handling this in doctrine/migrations instead of dbal, right?

[morozov]

Not necessarily. The problem may be in the DBAL itself but not in the schema manager but let's say in the comparator.

The best way to facilitate reasoning about the proper fix is to implement a failing scenario in code using the minimum of dependencies (e.g. w/o the ORM).

[PaulCombal]

Thanks for the guidance. I moved the logic to AbstractPlatform::columnsEqual. Is this appropriate?

I will of course write tests for the change once a maintainer confirms the code is at the right place.

[morozov]

I will of course write tests

Please start with an integration test.

[PaulCombal]

Turns out the test was already there, but the test case was not. I added it here.

Thank you for your patience.

[derrabus]

Apparently, your new test fails on SQL Server.

[derrabus]

It feels weird that a generic columnsEqual() method contains special treatment for one specific type. We should make sure that columnToArray() already produces comparable arrays.

[PaulCombal]

I thought so too, but then I remembered being told above:

Database drivers represent some numbers as strings for a reason

Also that means that all database platforms must represent floats in the same way (which I hope they do) so I can just cast them to php values.

If you tell me that's the way to go I would happily do that!

[PaulCombal]

Hi again, I implemented @derrabus 's solution instead, moving the logic into Column::toArray . It also fixes the test with mssql. Let me know if there's anything I can do to make this issue move forward.