WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Hide/show elements correctly when search is empty #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dule wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Hide/show elements correctly when search is empty #141

dule wants to merge 2 commits into from

Conversation

@dule
Copy link

@dule dule commented Sep 25, 2014

This fixes:

  1. Hiding the placeholder when there's input in the search box
  2. Hiding the cancel/clear button when the search box is empty

This includes the changes of #134 as both relies on the same check if the search box is truly empty and #134 is yet to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dule @goffrie