WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Cleanup | Consolidate connection capability metadata #3862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edwardneal wants to merge 23 commits into
base: main
Choose a base branch
from
+634 −484
Open

Cleanup | Consolidate connection capability metadata #3862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a6646c0
Add ConnectionCapabilities class
edwardneal Dec 27, 2025
e37f3a2
Hook LOGINACK handling
edwardneal Dec 27, 2025
de5c285
Update reference to _is20XX to reference Capabilities property
edwardneal Dec 27, 2025
65e701f
Errata: use BinaryPrimitives
edwardneal Dec 27, 2025
943c7db
Move handling of SqlLoginAck to ConnectionCapabilities
edwardneal Dec 27, 2025
c4ab86d
TdsEnums.cs constants cleanup
edwardneal Dec 27, 2025
d68b90c
Hook FEATUREEXT handling
edwardneal Dec 27, 2025
936218e
Move JSON feature detection handling
edwardneal Dec 27, 2025
53f8947
Move float32 vector feature detection handling
edwardneal Dec 27, 2025
8ee0fb4
Move Azure SQL feature detection handling
edwardneal Dec 27, 2025
7713018
Add additional detection logic for Global Transactions
edwardneal Dec 27, 2025
0e1fcc5
Move Global Transactions feature detection handling
edwardneal Dec 27, 2025
ade2336
Move data classification feature detection handling
edwardneal Dec 27, 2025
ab9ebff
Move initial SQL DNS caching feature detection handling
edwardneal Dec 28, 2025
abd69b7
Remove unnecessary _cleanSQLDNSCaching member
edwardneal Dec 28, 2025
50ccf47
Move column encryption feature detection handling
edwardneal Dec 28, 2025
24caa2a
Move logic to throw on unknown FEATUREEXT tokens into TdsParser
edwardneal Dec 28, 2025
984ac2e
Refactor parsing condition into ShouldProcessFeatureExtAck
edwardneal Dec 28, 2025
9380711
Maintain original server version behaviour
edwardneal Dec 28, 2025
95ac4f5
Performance: convert SqlLoginAck to a readonly ref struct
edwardneal Dec 28, 2025
229a04d
Enable Release mode build
edwardneal Dec 28, 2025
25b01d4
Plumb new ConnectionCapabilities to SqlMetaDataFactory
edwardneal Dec 28, 2025
6560f5f
Cross-check FEATUREEXT validation to original OnFeatureExtAck
edwardneal Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,9 @@
<Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Connection\CachedContexts.cs">
<Link>Microsoft\Data\SqlClient\Connection\CachedContexts.cs</Link>
</Compile>
<Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Connection\ConnectionCapabilities.cs">
<Link>Microsoft\Data\SqlClient\Connection\ConnectionCapabilities.cs</Link>
</Compile>
<Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Connection\ServerInfo.cs">
<Link>Microsoft\Data\SqlClient\Connection\ServerInfo.cs</Link>
</Compile>
Expand Down
3 changes: 3 additions & 0 deletions src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,9 @@
<Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Connection\CachedContexts.cs">
<Link>Microsoft\Data\SqlClient\Connection\CachedContexts.cs</Link>
</Compile>
<Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Connection\ConnectionCapabilities.cs">
<Link>Microsoft\Data\SqlClient\Connection\ConnectionCapabilities.cs</Link>
</Compile>
<Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Connection\ServerInfo.cs">
<Link>Microsoft\Data\SqlClient\Connection\ServerInfo.cs</Link>
</Compile>
Expand Down
Loading