WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Migrate filters.coffee #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
martindolores wants to merge 2 commits into
base: 9.x
Choose a base branch
from
Open

Migrate filters.coffee #938

martindolores wants to merge 2 commits into from

Conversation

@martindolores
Copy link

@martindolores martindolores commented Jun 15, 2025

Description

  • migrate all filters from filters.coffee to own file in same directory

Type of change

  • New feature (Migration)

How Has This Been Tested?

  1. Perform general smoke test on OnTrack

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

macite
macite requested changes Jun 17, 2025
View reviewed changes
Copy link
Member

@macite macite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also what is being removed?

src/app/common/filters/to_trusted.pipe.ts
constructor(private sanitizer: DomSanitizer) {}

transform(text: string): any {
return this.sanitizer.bypassSecurityTrustHtml(text);
Copy link
Member

@macite macite Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be calling sanitize not bypassing this.

@returnMarcco
Copy link

returnMarcco commented Aug 23, 2025

Hi @martindolores,
Just making you aware of the above feedback. Also, can you please update the 'Migration Progress List' in README.MD.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macite macite macite requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martindolores @returnMarcco @macite