fix: spec invalid rendered values "null" #11481

rogercoll · 2025-11-28T16:48:18Z

What does this PR do?

Modifies the kube-stack configurations to prevent "null" values in the Helm v4.
Bumps Helm v4 and its dependencies.

Why is it important?

Fixes the deployment with Helm 4, error message:

Error: Instrumentation.opentelemetry.io "elastic-instrumentation" is invalid: spec.env: Invalid value: "null": spec.env in body must be of type array: "null"
OpenTelemetryCollector.opentelemetry.io "opentelemetry-kube-stack-gateway" is invalid: [spec.config.service.pipelines.metrics/aggregated-otel-metrics.processors: Invalid value: "null": spec.config.service.pipelines.metrics/aggregated-otel-metrics.processors in body must be of type array: "null", <nil>: Invalid value: "null": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation]

Checklist

I have read and understood the pull request guidelines of this project.
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in ./changelog/fragments using the changelog tool
I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

How are we going to support this in production?
How are we going to measure its adoption?
How are we going to debug this?
What are the metrics I should take care of?
...

mergify · 2025-11-28T16:48:57Z

This pull request does not have a backport label. Could you fix it @rogercoll? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
backport-active-all is the label that automatically backports to all active branches.
backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

elasticmachine · 2025-12-04T11:42:22Z

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

swiatekm

Why do you need to bump Go dependencies in this PR?

rogercoll · 2025-12-09T08:52:39Z

Why do you need to bump Go dependencies in this PR?

That was a side effect of updating Helm dependency to v4 as defined in go.mod (check-ci was failing if only helm was bumped).

rogercoll · 2025-12-10T11:03:27Z

buildkite test this

ChrsMark · 2025-12-10T12:13:46Z

Hmm, should this be fixed in other places too? I see #11596 reports something similar.

rogercoll · 2025-12-10T14:00:25Z

Hmm, should this be fixed in other places too? I see #11596 reports something similar.

Definitely, not sure why this was not caught in previous CI runs. 583ba49

rogercoll · 2025-12-10T17:49:57Z

@swiatekm and @osullivandonal I end up rolling back the go.mod changes as it hasn't updating Helm to v4 at all. The repository upgrade to v4 requires breaking changes to a few files I am not familiar with. Opened this issue to tackle it a separate PR: #11727

For now, this PR prevents having null YAML objects which are permitted in Helm v3 but not in Helm v4

rogercoll · 2025-12-11T15:35:54Z

buildkite test this

elasticmachine · 2025-12-12T09:41:47Z

💚 Build Succeeded

Buildkite Build
Commit: d04d73e

History

💔 Build #31866 failed 3ec4a99
💔 Build #31862 failed 3ec4a99
💔 Build #31797 failed 5c21ed3
💛 Build #31769 was flaky 154d2e2
💔 Build #31753 failed b4de878

cc @rogercoll

github-actions · 2025-12-12T09:43:37Z

@Mergifyio backport 8.19 9.1 9.2

mergify · 2025-12-12T09:43:58Z

backport 8.19 9.1 9.2

✅ Backports have been created

#11771 [8.19] (backport #11481) fix: spec invalid rendered values "null" has been created for branch 8.19 but encountered conflicts
#11772 [9.1] (backport #11481) fix: spec invalid rendered values "null" has been created for branch 9.1 but encountered conflicts
#11773 [9.2] (backport #11481) fix: spec invalid rendered values "null" has been created for branch 9.2

* fix: spec invalid rendered values "null" * chore: add fragments * update helm to v4 * fix: k8s_events empty config * rollback go mod changes * rollback licenses (cherry picked from commit 6a7cd38) # Conflicts: # deploy/helm/edot-collector/kube-stack/managed_otlp/logs-values.yaml # deploy/helm/edot-collector/kube-stack/managed_otlp/values.yaml # deploy/helm/edot-collector/kube-stack/values.yaml

* fix: spec invalid rendered values "null" * chore: add fragments * update helm to v4 * fix: k8s_events empty config * rollback go mod changes * rollback licenses (cherry picked from commit 6a7cd38) # Conflicts: # deploy/helm/edot-collector/kube-stack/managed_otlp/values.yaml # deploy/helm/edot-collector/kube-stack/values.yaml

* fix: spec invalid rendered values "null" * chore: add fragments * update helm to v4 * fix: k8s_events empty config * rollback go mod changes * rollback licenses (cherry picked from commit 6a7cd38)

* fix: spec invalid rendered values "null" * chore: add fragments * update helm to v4 * fix: k8s_events empty config * rollback go mod changes * rollback licenses (cherry picked from commit 6a7cd38) Co-authored-by: Roger Coll <[email protected]>

…1771) * fix: spec invalid rendered values "null" (#11481) * fix: spec invalid rendered values "null" * chore: add fragments * update helm to v4 * fix: k8s_events empty config * rollback go mod changes * rollback licenses (cherry picked from commit 6a7cd38) # Conflicts: # deploy/helm/edot-collector/kube-stack/managed_otlp/logs-values.yaml # deploy/helm/edot-collector/kube-stack/managed_otlp/values.yaml # deploy/helm/edot-collector/kube-stack/values.yaml * fix conflicts --------- Co-authored-by: Roger Coll <[email protected]>

fix: spec invalid rendered values "null"

23c3572

mergify bot assigned rogercoll Nov 28, 2025

rogercoll added 2 commits November 28, 2025 17:53

chore: add fragments

9972c2b

Merge branch 'main' into fix_helm_4

4f6674b

rogercoll marked this pull request as ready for review December 4, 2025 11:04

rogercoll requested review from a team as code owners December 4, 2025 11:04

rogercoll requested review from blakerouse and pchila December 4, 2025 11:13

rogercoll force-pushed the fix_helm_4 branch from 1af79f8 to 6b06509 Compare December 4, 2025 11:32

pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Dec 4, 2025

rogercoll force-pushed the fix_helm_4 branch from 6b06509 to fcdc95d Compare December 4, 2025 12:16

update helm to v4

e188928

rogercoll force-pushed the fix_helm_4 branch from fcdc95d to e188928 Compare December 4, 2025 13:36

osullivandonal previously approved these changes Dec 4, 2025

View reviewed changes

Merge branch 'main' into fix_helm_4

bc031f9

swiatekm reviewed Dec 5, 2025

View reviewed changes

Merge branch 'main' into fix_helm_4

1a6f821

rogercoll added 2 commits December 10, 2025 08:41

Merge branch 'main' into fix_helm_4

9888419

Merge branch 'main' into fix_helm_4

b4de878

swiatekm previously approved these changes Dec 10, 2025

View reviewed changes

fix: k8s_events empty config

583ba49

rogercoll dismissed stale reviews from swiatekm and osullivandonal via 583ba49 December 10, 2025 13:58

Merge branch 'main' into fix_helm_4

154d2e2

swiatekm previously approved these changes Dec 10, 2025

View reviewed changes

osullivandonal previously approved these changes Dec 10, 2025

View reviewed changes

rollback go mod changes

cf9f4b8

rogercoll dismissed stale reviews from osullivandonal and swiatekm via cf9f4b8 December 10, 2025 17:31

rollback licenses

5714d92

rogercoll force-pushed the fix_helm_4 branch from b59e62d to 5714d92 Compare December 10, 2025 17:42

Merge branch 'main' into fix_helm_4

5c21ed3

osullivandonal mentioned this pull request Dec 11, 2025

[Feature] Add interactive mode to demo.sh with deployment type selection elastic/opentelemetry-demo#182

Merged

3 tasks

Merge branch 'main' into fix_helm_4

3ec4a99

Merge branch 'main' into fix_helm_4

d04d73e

osullivandonal approved these changes Dec 12, 2025

View reviewed changes

rogercoll merged commit 6a7cd38 into elastic:main Dec 12, 2025
21 checks passed

rogercoll added the backport-active-all Automated backport with mergify to all the active branches label Dec 12, 2025

mergify bot mentioned this pull request Dec 12, 2025

[8.19] (backport #11481) fix: spec invalid rendered values "null" #11771

Merged

8 tasks

This was referenced Dec 12, 2025

[9.1] (backport #11481) fix: spec invalid rendered values "null" #11772

Open

[9.2] (backport #11481) fix: spec invalid rendered values "null" #11773

Merged

rogercoll mentioned this pull request Dec 12, 2025

chore: bump kube-stack Helm chart onboarding to 0.12.4 elastic/kibana#246211

Open

10 tasks

fix: spec invalid rendered values "null" #11481

fix: spec invalid rendered values "null" #11481

Conversation

rogercoll commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

Uh oh!

mergify bot commented Nov 28, 2025

Uh oh!

elasticmachine commented Dec 4, 2025

Uh oh!

swiatekm left a comment

Choose a reason for hiding this comment

Uh oh!

rogercoll commented Dec 9, 2025

Uh oh!

rogercoll commented Dec 10, 2025

Uh oh!

ChrsMark commented Dec 10, 2025

Uh oh!

rogercoll commented Dec 10, 2025

Uh oh!

rogercoll commented Dec 10, 2025

Uh oh!

rogercoll commented Dec 11, 2025

Uh oh!

elasticmachine commented Dec 12, 2025

💚 Build Succeeded

History

Uh oh!

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

mergify bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rogercoll commented Nov 28, 2025 •

edited

Loading

mergify bot commented Dec 12, 2025 •

edited

Loading