WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@michel-laterman
Copy link
Contributor

What does this PR do?

Add an integration test that requires a download_proxy to be used.
This test will attempt to upgrade a fleet-managed agent, fail initially, add a download proxy and succeed in the upgrade.

Why is it important?

Untested workflow that has caused previous bugs.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

N/A

Related issues

@michel-laterman michel-laterman added Testing Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Dec 3, 2025
@mergify
Copy link
Contributor

mergify bot commented Dec 3, 2025

This pull request does not have a backport label. Could you fix it @michel-laterman? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@michel-laterman michel-laterman force-pushed the test/integration-download-proxy branch 2 times, most recently from 9766995 to 54baf2b Compare December 4, 2025 01:04
@michel-laterman michel-laterman force-pushed the test/integration-download-proxy branch 3 times, most recently from 01f1f47 to 5ad7bbd Compare December 4, 2025 01:21
@michel-laterman michel-laterman force-pushed the test/integration-download-proxy branch from 5ad7bbd to 921a401 Compare December 5, 2025 19:25
@michel-laterman michel-laterman force-pushed the test/integration-download-proxy branch from 921a401 to b2ec761 Compare December 5, 2025 19:29
@michel-laterman michel-laterman marked this pull request as ready for review December 5, 2025 19:30
@michel-laterman michel-laterman requested a review from a team as a code owner December 5, 2025 19:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. I have two comments inline.

@elasticmachine
Copy link
Contributor

@michel-laterman michel-laterman enabled auto-merge (squash) December 11, 2025 16:36
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fixes.

@michel-laterman michel-laterman merged commit 8c0f918 into elastic:main Dec 12, 2025
21 checks passed
@michel-laterman michel-laterman deleted the test/integration-download-proxy branch December 12, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an upgrade test to confirm upgrades can succeed when a binary download proxy is configured

4 participants