WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Dec 10, 2025

What does this PR do?

In packaging tests, add a check to each packaged artifact to validate that all the expected components, and no extras, exist in the artifact for the package variant which is being validated.

FIPS packages are not included in the new checks, as they already have a more sophisticated check in func checkFIPS, and a different list of components.

Why is it important?

If the built artifacts are unexpectedly missing a component, or have an extra unexpected component, it will now be caught in tests.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

N/A

Add a check to each packaged artifact type to validate that all the expected
components, and no extras, exist in the artifact for the package variant
which is being built.

FIPS packages are not included in the new checks, as they already have a
more sophisticated check in checkFIPS, and a different list of
components.
@mergify mergify bot assigned mjwolf Dec 10, 2025
@mergify
Copy link
Contributor

mergify bot commented Dec 10, 2025

This pull request does not have a backport label. Could you fix it @mjwolf? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@mjwolf
Copy link
Contributor Author

mjwolf commented Dec 10, 2025

These tests will fail until #11450 is merged (these tests expect cloud-defend component already)

@mjwolf mjwolf marked this pull request as ready for review December 10, 2025 19:48
@mjwolf mjwolf requested a review from a team as a code owner December 10, 2025 19:48
@mjwolf mjwolf enabled auto-merge (squash) December 10, 2025 19:57
@mjwolf mjwolf marked this pull request as draft December 11, 2025 01:00
auto-merge was automatically disabled December 11, 2025 01:00

Pull request was converted to draft

There are component difference in packages depending on the package test
(connectors and cloud-defend are only in docker), so the component check
is updated to take this into account.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants