-
Notifications
You must be signed in to change notification settings - Fork 204
Add packaging checks to validate component existence #11703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mjwolf
wants to merge
9
commits into
elastic:main
Choose a base branch
from
mjwolf:validate-package-contents
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+260
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check to each packaged artifact type to validate that all the expected components, and no extras, exist in the artifact for the package variant which is being built. FIPS packages are not included in the new checks, as they already have a more sophisticated check in checkFIPS, and a different list of components.
Contributor
|
This pull request does not have a backport label. Could you fix it @mjwolf? 🙏
|
Contributor
Author
|
These tests will fail until #11450 is merged (these tests expect cloud-defend component already) |
There are component difference in packages depending on the package test (connectors and cloud-defend are only in docker), so the component check is updated to take this into account.
Contributor
💔 Build Failed
Failed CI Steps
History
cc @mjwolf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In packaging tests, add a check to each packaged artifact to validate that all the expected components, and no extras, exist in the artifact for the package variant which is being validated.
FIPS packages are not included in the new checks, as they already have a more sophisticated check in
func checkFIPS, and a different list of components.Why is it important?
If the built artifacts are unexpectedly missing a component, or have an extra unexpected component, it will now be caught in tests.
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
N/A