feat: better buffering on move-ins #3525
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3525 +/- ##
==========================================
- Coverage 75.24% 75.21% -0.03%
==========================================
Files 51 51
Lines 2743 2744 +1
Branches 404 408 +4
==========================================
Hits 2064 2064
- Misses 677 678 +1
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
icehaunter
force-pushed
the
ilia/pr/rmysvxopsvsz
branch
from
ed304ff to
8245f1f
Compare
icehaunter
force-pushed
the
ilia/pr/kwsxvzwsrqpo
branch
2 times, most recently
from
6a67a9c to
a0ddeb9
Compare
icehaunter
force-pushed
the
ilia/pr/rmysvxopsvsz
branch
2 times, most recently
from
bda1aa9 to
e1473b8
Compare
icehaunter
force-pushed
the
ilia/pr/kwsxvzwsrqpo
branch
from
a0ddeb9 to
5cdd0b2
Compare
icehaunter
force-pushed
the
ilia/pr/kwsxvzwsrqpo
branch
2 times, most recently
from
2d913ea to
4f6baa1
Compare
robacourt
reviewed
Dec 1, 2025
Comment on lines
29
to
30
| defdelegate append_move_in_snapshot_to_log!(name, writer_state), to: PureFileStorage | ||
| defdelegate append_move_in_snapshot_to_log_filtered!(name, writer_state, touch_tracker, snapshot), to: PureFileStorage |
Contributor
There was a problem hiding this comment.
Do we need both or can this new one replace the old one?
robacourt
approved these changes
Dec 2, 2025
Contributor
robacourt
left a comment
robacourt
left a comment
There was a problem hiding this comment.
LGTM. Nice optimisation!
icehaunter
force-pushed
the
ilia/pr/kwsxvzwsrqpo
branch
from
4f6baa1 to
30e928a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.