Remove Capnp as a Required Dependency #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonoPrest
commented
Feb 27, 2025
Comment on lines
28
to
33
| - name: Check capnp schema should match the generated code | ||
| run: | | ||
| export DEBIAN_FRONTEND=noninteractive | ||
| sudo apt-get install -y capnproto libcapnp-dev | ||
| - name: Build | ||
| run: cargo build | ||
| - name: Test | ||
| run: cargo test | ||
| make capnp-build | ||
| git diff --exit-code |
Collaborator
Author
There was a problem hiding this comment.
Should prove that capnproto does not need to be included
JonoPrest
force-pushed
the
jp/remove-capnp-dep
branch
from
8f7aafc to
60f63c2
Compare
JonoPrest
force-pushed
the
jp/remove-capnp-dep
branch
from
64ddf13 to
424e61c
Compare
JonoPrest
force-pushed
the
jp/remove-capnp-dep
branch
from
6b5d584 to
a29a954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have now put the capnp build script into a make file to be manually run.
It puts the artifact straight into the src file and formats it.
The CI can then check if anything has changed.