WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@TDA-2030
Copy link
Collaborator

Description

  • Corrected the incorrect function name esp_ptr_in_psram to esp_ptr_external_ram

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

if (esp_ptr_in_dram(ptr) || esp_ptr_in_diram_dram(ptr)
#if CONFIG_SPIRAM
|| esp_ptr_in_psram(ptr)
|| esp_ptr_external_ram(ptr)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my interest, what was the issue here? Is the esp_ptr_in_psram() deprecated?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also find this strange. This function doesn't seem to exist in esp-idf, and I can't remember how the name esp_ptr_in_psram came about. 😢 I just found that when using PSRAM, the compilation error message indicated that this function was not declared.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interresting. That might be also a good test case. For example to build the uac example in CI with the PSRAM enabled.

For example something like here: sdkconfig.ci.esp32p4_psram

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already put that file in directory 'host/class/uac/usb_host_uac/test_app', is that okay?

@peter-marcisovsky
Copy link
Collaborator

Regarding the failing CI, there is a build error the fix is in #352

@TDA-2030 TDA-2030 force-pushed the fix/usb_host_uac_error_function_name branch from 126322d to c27db32 Compare December 11, 2025 11:16
@TDA-2030 TDA-2030 force-pushed the fix/usb_host_uac_error_function_name branch from c27db32 to 3bdf935 Compare December 12, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants