feat: add text/csv media type support #321
Merged
+126
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@fabien0102 |
fabien0102
requested changes
Dec 8, 2025
Owner
fabien0102
left a comment
fabien0102
left a comment
There was a problem hiding this comment.
Almost perfect! Thanks for the contribution! Just a little improvement on the types and we are good to go
| }); | ||
|
|
||
| it("should return MediaTypeObject for application/json", () => { | ||
| const mediaTypeObject = { schema: { type: "object" as const } }; |
Owner
There was a problem hiding this comment.
Suggested change
| const mediaTypeObject = { schema: { type: "object" as const } }; | |
| const mediaTypeObject: MediaTypeObject = { schema: { type: "object" } }; |
You need to import MediaTypeObject from "openapi3-ts/oas30";
Contributor
Author
There was a problem hiding this comment.
@fabien0102
Thank you for reviewing it so quickly.
I’ve made the corrections you pointed out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for
text/csvmedia type in the TypeScript code generator.Problem
When OpenAPI specifications defined endpoints with
text/csvresponses, thefindCompatibleMediaTypefunction did not recognize this media type, resulting inundefinedtypes in the generated TypeScript code.