Consider an uninitialised ClassVar as abstract #1797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We may need to special-case |
As per title, this diff addresses the last remaining issue in the conformance test `protocols_explicit.py` by requiring declared classvar members to be initialised for protocols.
fangyi-zhou
force-pushed
the
uninit-classvar-is-abstract
branch
from
aec4db2 to
31b6e61
Compare
fangyi-zhou
force-pushed
the
uninit-classvar-is-abstract
branch
from
31b6e61 to
212887d
Compare
Contributor
Author
|
Got another issue with typeshed: I start to think we should not consider |
|
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D88902254. |
Contributor
How widespread is it? I think it sounds reasonable to exclude ClassVars in stubs for now, especially if it's common. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As per title, this diff addresses the last remaining issue in the
conformance test
protocols_explicit.pyby requiring declared classvarmembers to be initialised for protocols.
The exception is that uninitialised class variables in interface files are not considered abstract. This exception is necessary to get around issues in typeshed.
Test Plan
python test.py