-
Notifications
You must be signed in to change notification settings - Fork 747
Add quit and relaunch logic to macOS FMAs #37670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
allenhouchins
wants to merge
6
commits into
main
Choose a base branch
from
allenhouchins-add-quit-relaunch-logic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+131
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleet-release
previously approved these changes
Dec 24, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #37670 +/- ##
==========================================
- Coverage 65.88% 65.88% -0.01%
==========================================
Files 2360 2360
Lines 187285 187290 +5
Branches 8006 8005 -1
==========================================
- Hits 123402 123390 -12
- Misses 52605 52618 +13
- Partials 11278 11282 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fleet-release
previously approved these changes
Dec 24, 2025
fleet-release
previously approved these changes
Dec 24, 2025
fleet-release
approved these changes
Dec 24, 2025
fleet-release
approved these changes
Dec 24, 2025
fleet-release
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the macOS app installation process by improving how running applications are handled during install and update, and also updates the metadata and scripts for Docker Desktop. The main improvements are the introduction of quit/relaunch logic for pkg-based FMAs, and the renaming and updating of Docker Desktop’s identifiers and scripts.
App install/relaunch improvements:
quit_and_track_applicationandrelaunch_applicationto the generated install scripts. These functions ensure that if an app (or pkg) is running before installation, it is quit and then automatically relaunched after installation, preserving user state. The logic tracks whether the app was running via an environment variable. [1] [2] [3] [4]quit_applicationlogic from the install script generation, as the new functions supersede it.Docker Desktop metadata and script updates:
slugandunique_identifierto match the new bundle identifier (com.electron.dockerdesktop), reflecting the current packaging.apps.jsonto use the new slug and unique identifier for Docker Desktop.docker-desktop/darwin.json) with the updated install and uninstall scripts, including the new quit/relaunch logic and references.