WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@allenhouchins
Copy link
Member

@allenhouchins allenhouchins commented Dec 24, 2025

This pull request enhances the macOS app installation process by improving how running applications are handled during install and update, and also updates the metadata and scripts for Docker Desktop. The main improvements are the introduction of quit/relaunch logic for pkg-based FMAs, and the renaming and updating of Docker Desktop’s identifiers and scripts.

App install/relaunch improvements:

  • Added new shell functions quit_and_track_application and relaunch_application to the generated install scripts. These functions ensure that if an app (or pkg) is running before installation, it is quit and then automatically relaunched after installation, preserving user state. The logic tracks whether the app was running via an environment variable. [1] [2] [3] [4]
  • Removed the previous simpler quit_application logic from the install script generation, as the new functions supersede it.

Docker Desktop metadata and script updates:

  • Renamed the Docker Desktop input and updated its slug and unique_identifier to match the new bundle identifier (com.electron.dockerdesktop), reflecting the current packaging.
  • Updated the output app metadata in apps.json to use the new slug and unique identifier for Docker Desktop.
  • Added a new output file for Docker Desktop (docker-desktop/darwin.json) with the updated install and uninstall scripts, including the new quit/relaunch logic and references.

fleet-release
fleet-release previously approved these changes Dec 24, 2025
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.88%. Comparing base (9adfe73) to head (68d34ee).

Files with missing lines Patch % Lines
ee/maintained-apps/ingesters/homebrew/scripts.go 8.33% 9 Missing and 2 partials ⚠️
...end/pages/SoftwarePage/components/icons/Docker.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #37670      +/-   ##
==========================================
- Coverage   65.88%   65.88%   -0.01%     
==========================================
  Files        2360     2360              
  Lines      187285   187290       +5     
  Branches     8006     8005       -1     
==========================================
- Hits       123402   123390      -12     
- Misses      52605    52618      +13     
- Partials    11278    11282       +4     
Flag Coverage Δ
backend 67.73% <8.33%> (-0.01%) ⬇️
frontend 54.40% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fleet-release
fleet-release previously approved these changes Dec 24, 2025
fleet-release
fleet-release previously approved these changes Dec 24, 2025
@allenhouchins allenhouchins marked this pull request as ready for review December 24, 2025 06:19
@allenhouchins allenhouchins requested review from a team as code owners December 24, 2025 06:19
@fleet-release fleet-release requested a review from eashaw December 24, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants