WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

fixed throwing an exception when process contains two boundary events… #3958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ywling417 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fixed throwing an exception when process contains two boundary events… #3958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f73883
fixed throwing an exception when process contains two boundary events…
Sep 10, 2024
0babcec
fixed the project import ordering
ywling417 Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...owable-engine/src/main/java/org/flowable/engine/impl/agenda/ContinueProcessOperation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,12 @@ protected void executeBoundaryEvents(List<BoundaryEvent> boundaryEvents, List<Ex

while (boundaryEventsIterator.hasNext() && boundaryEventExecutionsIterator.hasNext()) {
BoundaryEvent boundaryEvent = boundaryEventsIterator.next();
if (!(boundaryEvent.getBehavior() instanceof BoundaryEventRegistryEventActivityBehavior)) {
if (CollectionUtil.isEmpty(boundaryEvent.getEventDefinitions())
|| (boundaryEvent.getEventDefinitions().get(0) instanceof CompensateEventDefinition)) {
continue;
}
}
ExecutionEntity boundaryEventExecution = boundaryEventExecutionsIterator.next();
ActivityBehavior boundaryEventBehavior = ((ActivityBehavior) boundaryEvent.getBehavior());
LOGGER.debug("Executing boundary event activityBehavior {} with execution {}", boundaryEventBehavior.getClass(), boundaryEventExecution.getId());
Expand Down
7 changes: 7 additions & 0 deletions ...ine/src/test/java/org/flowable/engine/test/bpmn/event/compensate/CompensateEventTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,4 +337,11 @@ public void testCompensateNestedSubprocess() {

}

@Test
@Deployment
public void testTwoBoundaryEventAndFirstIsCompensation() {
ProcessInstance processInstance = runtimeService.startProcessInstanceByKey("compensateProcess");
assertThat(processInstance).isNotNull();
}

}
29 changes: 29 additions & 0 deletions ...vent/compensate/CompensateEventTest.testTwoBoundaryEventAndFirstIsCompensation.bpmn20.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?xml version="1.0" encoding="UTF-8"?>
<definitions xmlns="http://www.omg.org/spec/BPMN/20100524/MODEL"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns:xsd="http://www.w3.org/2001/XMLSchema"
xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI"
xmlns:omgdc="http://www.omg.org/spec/DD/20100524/DC"
xmlns:omgdi="http://www.omg.org/spec/DD/20100524/DI"
xmlns:flowable="http://flowable.org/bpmn"
typeLanguage="http://www.w3.org/2001/XMLSchema"
expressionLanguage="http://www.w3.org/1999/XPath"
targetNamespace="http://www.flowable.org/processdef">

<process id="compensateProcess">

<startEvent id="start"/>
<sequenceFlow sourceRef="start" targetRef="user"/>
<userTask id="user"/>
<boundaryEvent id="compensate" attachedToRef="user">
<compensateEventDefinition />
</boundaryEvent>
<boundaryEvent id="error" attachedToRef="user">
<errorEventDefinition errorRef="myError"/>
</boundaryEvent>

<sequenceFlow sourceRef="user" targetRef="end"/>
<endEvent id="end"/>
</process>

</definitions>