WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@cn-xufei
Copy link
Contributor

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from main or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

1. Changes in packages/components/src/form-dialog/index.ts:

  • Moved render logic from render() to setup() for better Vue 3 composition API alignment
  • Simplified event handlers by removing unnecessary arrow functions
  • Fixed typo: renamed 'onOpend' to 'onOpened'
  • Improved code organization and readability
  • Added proper component instance cleanup in onClosed hook using vueRender(null, env.root)

2. Changes in package.json:

  • Added resolutions field to fix tslib export error:
    "resolutions": {
      "**/rollup-plugin-typescript2": "^0.31.0"
    }
  • This forces a specific version of rollup-plugin-typescript2 that has compatible tslib exports configuration
  • Resolves the "Package subpath './package.json' is not defined by exports" error

@netlify
Copy link

netlify bot commented Apr 15, 2025

Deploy Preview for formily-element-plus failed. Why did it fail? →

Name Link
🔨 Latest commit faa075e
🔍 Latest deploy log https://app.netlify.com/sites/formily-element-plus/deploys/67fdf8af1a9d9a00084c79da

@cn-xufei cn-xufei changed the title Fix/form dialog fix(form-dialog): correct typo in onOpened event and improve portal setup Apr 15, 2025
…cript2

Fix:
- Add resolutions field to force rollup-plugin-typescript2@^0.31.0
- This version has compatible tslib exports configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant