WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@frappe-pr-bot
Copy link
Collaborator

@frappe-pr-bot frappe-pr-bot commented Dec 7, 2025

Summary by CodeRabbit

  • Chores
    • Updated Slovenian language translations with additional translations for specific terms ("OUT" → "IZHOD", "Oct" → "Okt").
    • Updated localization metadata.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 7, 2025

Walkthrough

The changes involve updates to a Slovenian translation file (hrms/locale/sl.po). The POT revision date was updated from 2025-12-05 09:07 to 2025-12-07 09:18. Two translation entries were modified: "OUT" was translated to "IZHOD" and "Oct" was translated to "Okt". These are minor localization updates with no functional behavior changes.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'fix: sync translations from crowdin' accurately describes the changeset, which contains Slovenian translation updates synced from Crowdin with an updated POT revision date.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
hrms/locale/sl.po (1)

6-6: Header nit: add timezone to PO-Revision-Date (optional).

Recommend including a timezone offset (e.g., +0000) per gettext convention for consistency with POT-Creation-Date.

-"PO-Revision-Date: 2025-12-07 09:18\n"
+"PO-Revision-Date: 2025-12-07 09:18+0000\n"
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89a2c22 and 49e50f1.

📒 Files selected for processing (1)
  • hrms/locale/sl.po (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Summary
🔇 Additional comments (1)
hrms/locale/sl.po (1)

6947-6949: LGTM: month abbreviation.

“Oct” → “Okt” is correct.

Comment on lines 6937 to 6939
msgid "OUT"
msgstr ""
msgstr "IZHOD"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Prefer ‘ODJAVA’ for ‘OUT’ to mirror ‘PRIJAVA’ and UI phrasing.

Aligns with existing “IN” → “PRIJAVA” and “Check Out” → “Odjavi se”.

 msgid "OUT"
-msgstr "IZHOD"
+msgstr "ODJAVA"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
msgid "OUT"
msgstr ""
msgstr "IZHOD"
msgid "OUT"
msgstr "ODJAVA"
🤖 Prompt for AI Agents
In hrms/locale/sl.po around lines 6937 to 6939, the Slovenian translation for
msgid "OUT" currently uses "IZHOD" but should be changed to "ODJAVA" to match
existing UI phrasing (mirroring "IN" → "PRIJAVA" and "Check Out" → "Odjavi se");
update the msgstr to "ODJAVA" and keep formatting consistent with surrounding
entries.

@asmitahase asmitahase merged commit 5c7873f into develop Dec 8, 2025
4 checks passed
@frappe-pr-bot frappe-pr-bot deleted the l10n_develop branch December 8, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants