fix(role): Added role Press Billing Manager to add/edit billing address #3729
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (44.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #3729 +/- ##
===========================================
- Coverage 44.85% 44.83% -0.03%
===========================================
Files 712 709 -3
Lines 48221 48230 +9
===========================================
- Hits 21630 21623 -7
- Misses 26591 26607 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bowrna
changed the title
| data=ex, | ||
| reference_doctype="Team", | ||
| ) | ||
| billing_details = frappe._dict(billing_details) |
There was a problem hiding this comment.
I have added this try block part by mistake in develop branch. This will swallow the issue without raising to the user
| def add_press_billing_manager_role(self, user): | ||
| self.add_press_role(user, "Press Billing Manager") | ||
|
|
||
| def add_press_admin_role(self, user): |
There was a problem hiding this comment.
With Press Billing Manager, do we still need this method? I think we can safely remove it.
2 participants
Edit: Add new role "Press Billing Manager". Giving permission across doctypes related to billing. Giving appropriate permissions through settings page.