WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@Aradhya-Tripathi
Copy link
Contributor

@Aradhya-Tripathi Aradhya-Tripathi commented Dec 2, 2025

  • Discount on original app server price (10%)
  • Ignore usage record creation in the subscription doctype
  • Create usage record on scale down event calculation scaled duration using the last successful scale up record.
  • Adjusted quantity in the Invoice as the total usage minutes.

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 18.39080% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.85%. Comparing base (76f69ad) to head (3cce420).
⚠️ Report is 21 commits behind head on develop.

Files with missing lines Patch % Lines
...ess/doctype/auto_scale_record/auto_scale_record.py 14.28% 24 Missing ⚠️
press/api/server.py 18.18% 18 Missing ⚠️
press/press/doctype/invoice/invoice.py 43.75% 9 Missing ⚠️
...ype/nfs_volume_attachment/nfs_volume_attachment.py 0.00% 8 Missing ⚠️
...ype/nfs_volume_detachment/nfs_volume_detachment.py 0.00% 8 Missing ⚠️
press/press/doctype/subscription/subscription.py 25.00% 3 Missing ⚠️
press/press/doctype/server/server.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (18.39%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4089      +/-   ##
===========================================
- Coverage    44.89%   44.85%   -0.05%     
===========================================
  Files          726      725       -1     
  Lines        49737    49809      +72     
===========================================
+ Hits         22331    22341      +10     
- Misses       27406    27468      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Aradhya-Tripathi Aradhya-Tripathi requested review from shadrak98 and removed request for regdocs December 7, 2025 08:11
@Aradhya-Tripathi Aradhya-Tripathi merged commit 2f2aa98 into develop Dec 8, 2025
6 of 7 checks passed
@Aradhya-Tripathi Aradhya-Tripathi deleted the auto-scale-pricing branch December 8, 2025 05:04
Aradhya-Tripathi added a commit that referenced this pull request Dec 8, 2025
feat(pricing): Auto scale pricing (backport #4089)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants