WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Oct 6, 2025

  • The Switch App Page event action was not working. It was using the old router mechanism
  • Added a toast notification to display a user-friendly error when navigation fails due to a non-existent or unpublished page in the router's beforeEach hook.
  • Remove the catch-all AppContainer route before registering new dynamic app routes. If the catch-all route is registered, all non-existent app routes are also considered valid
image
navigation-failure.mp4

Closes: #113

Other:

  • fix: New Page button doesn't work for the first time due to undefined appID

- it was using the old router mechanism
- if the catch all route is registered, all non-existent app routes are also considered as valid
@ruchamahabal ruchamahabal merged commit 448c212 into frappe:develop Oct 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Action(Switch App Page) on click, hangs the Frappe Studio frontend once published.

1 participant