WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

feat(Data Sources): ability to wire success/error scripts + refactor code state management #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ruchamahabal merged 17 commits into from
Nov 11, 2025
Merged

feat(Data Sources): ability to wire success/error scripts + refactor code state management #126

ruchamahabal merged 17 commits into from
Nov 11, 2025

Conversation

@ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Nov 7, 2025 •
edited
Loading

Configure Success & Failure fields

Empty State:

image

Events Wired:

1-config-success-failure

In Action:

config-success-failure.mp4

Other major changes

  • studioStore & appStore were duplicating a lot of code for variables, resources & watcher management with some changes. Added a shared store among the two - codeStore that maintains state for the app in edit mode/render mode.
  • Commonified a lot of event handlers sitting in component files + helpers.ts in the store
  • refactor: drop extra checkbox for flagging transformed results. Follow event handler's UI pattern (empty state to configure)

@ruchamahabal
fix: broken reactivity in route object reference
40008f1
@ruchamahabal
refactor: commonify success/error handlers in code store for events &…
7fe2132 
… data sources
@ruchamahabal
fix: variable configs incorrectly initialized
7ff4997
@ruchamahabal
fix: watcher execution
40042e1
@ruchamahabal
fix: resource deletion not working
564381d
@ruchamahabal
fix: clear variables, resources before setting new ones
285f93a 
- data panel showed stale resources even after deletion
@ruchamahabal
fix: use completions for editable values in Data Panel response handlers
826186d
@ruchamahabal
refactor: drop extra checkbox for flagging transformed results
9e94f07 
- follow event handler's UI pattern
@ruchamahabal
refactor: extract ScriptSection component for transforms, success, fa…
b1dfcd2 
…ilure
@ruchamahabal
fix: set min-height for script header to avoid decreasing height when…
27a35d6 
… cancel btn is shown
@ruchamahabal
fix: stale depends on property for transform field
c1a49e4
@ruchamahabal
fix: incorrect route object in doc fetch filters
ef0e7e9 
- due to this the first document was being fetched everytime irrespective of the param ID
@ruchamahabal ruchamahabal marked this pull request as ready for review November 11, 2025 05:19
@ruchamahabal ruchamahabal changed the title feat(Data Sources): ability to wire success/error scripts feat(Data Sources): ability to wire success/error scripts + refactor code state management Nov 11, 2025
@ruchamahabal ruchamahabal merged commit abe7e81 into frappe:develop Nov 11, 2025
1 check passed
@ruchamahabal ruchamahabal moved this to Done in Frappe Studio Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

Frappe Studio
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ruchamahabal