[Bug Fix] http sink NEP checkpoint restore issue #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@grzegorz8 @kzarzycki @AdrianVasiliu @MarekMaj Hi guys, could you help review this issue and PR? It will be helpful for the users who use this repo. |
davidradl
reviewed
Dec 4, 2025
src/main/java/com/getindata/connectors/http/internal/sink/HttpSinkInternal.java
Outdated
Show resolved
Hide resolved
davidradl
reviewed
Dec 12, 2025
| Collection<BufferedRequestState<HttpSinkRequestEntry>> recoveredState) | ||
| throws IOException { | ||
|
|
||
| initElementConverterOfSchema(context); |
Collaborator
There was a problem hiding this comment.
please could you add a unit test for the new line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The target of this PR is to fix the below issue, you can check the detail following the link. The root cause is the mapper is null, the method open() can't be initiated when the job restore from the checkpoint. We must initiate it on restoreWriter just like createWriter.
Target
Resolves issue 195
PR Checklist