Do not fail on mapping empty collections #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is quite natural for map function to be a no-op and return an empty collection when input is also empty (the examples are the python's own map funvtion and nodejs' array.map function) rather than throwing an error which it does at the moment.
|
Hi, is there any possibility of merging this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite natural for map function to be a no-op and return an empty collection when input is also empty (the examples are the python's own
mapfunction and nodejs'array.map) rather than throwing an error which it does at the moment.Itermap does seem to be working this way already bu i've added a test for an empty input as well, just in case.