WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Dec 1, 2025

Remove the unused function MostMatchSorter, it should not be implemented in golang, should be implement in the db query.
Remove the unused function onBoardCommonUserGroup()
fixes #22573

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner December 1, 2025 06:52
@stonezdj stonezdj added the release-note/update Update or Fix label Dec 1, 2025
@stonezdj stonezdj force-pushed the 25nov24_fix_search_user_usergroup branch from 923a8f4 to caaf7a5 Compare December 1, 2025 06:53
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 42.10526% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.86%. Comparing base (c8c11b4) to head (55e2bd2).
⚠️ Report is 598 commits behind head on main.

Files with missing lines Patch % Lines
src/pkg/user/dao/dao.go 57.14% 4 Missing and 2 partials ⚠️
src/pkg/usergroup/dao/dao.go 57.14% 4 Missing and 2 partials ⚠️
src/controller/user/controller.go 0.00% 2 Missing ⚠️
src/controller/usergroup/controller.go 0.00% 2 Missing ⚠️
src/pkg/user/manager.go 0.00% 2 Missing ⚠️
src/pkg/usergroup/manager.go 0.00% 2 Missing ⚠️
src/server/v2.0/handler/user.go 0.00% 1 Missing ⚠️
src/server/v2.0/handler/usergroup.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22606       +/-   ##
===========================================
+ Coverage   45.36%   65.86%   +20.49%     
===========================================
  Files         244     1073      +829     
  Lines       13333   116095   +102762     
  Branches     2719     2931      +212     
===========================================
+ Hits         6049    76468    +70419     
- Misses       6983    35386    +28403     
- Partials      301     4241     +3940     
Flag Coverage Δ
unittests 65.86% <42.10%> (+20.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/common/utils/utils.go 82.23% <ø> (ø)
src/server/v2.0/handler/user.go 18.44% <0.00%> (ø)
src/server/v2.0/handler/usergroup.go 0.00% <0.00%> (ø)
src/controller/user/controller.go 15.57% <0.00%> (ø)
src/controller/usergroup/controller.go 18.18% <0.00%> (ø)
src/pkg/user/manager.go 53.84% <0.00%> (ø)
src/pkg/usergroup/manager.go 53.24% <0.00%> (ø)
src/pkg/user/dao/dao.go 53.16% <57.14%> (ø)
src/pkg/usergroup/dao/dao.go 52.52% <57.14%> (ø)

... and 978 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stonezdj stonezdj force-pushed the 25nov24_fix_search_user_usergroup branch from caaf7a5 to 5e82e94 Compare December 2, 2025 06:18
@stonezdj stonezdj force-pushed the 25nov24_fix_search_user_usergroup branch from 5e82e94 to 55e2bd2 Compare December 2, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/update Update or Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot submit form to assign a role to a group

4 participants