feat: Pipelines enters public preview #2272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup nix for idx
…uandy/PipelineResult
pipeline result
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
the
api: firestore
wu-hui
force-pushed
the
feat/pipeline/private-preview
branch
3 times, most recently
from
3aece03 to
bd317e2
Compare
wu-hui
force-pushed
the
feat/pipeline/private-preview
branch
from
f5e464b to
651bd3d
Compare
wu-hui
force-pushed
the
feat/pipeline/private-preview
branch
from
651bd3d to
6ae12ec
Compare
Contributor
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
PR title will be in the change log, so be sure to update this
Contributor
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
Initial review. It looks like there are a few API changes that need to be ported from Android
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Pipeline.java
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Pipeline.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Pipeline.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Pipeline.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/PipelineResult.java
Outdated
Show resolved
Hide resolved
...restore/src/main/java/com/google/cloud/firestore/pipeline/expressions/AggregateFunction.java
Show resolved
Hide resolved
...irestore/src/main/java/com/google/cloud/firestore/pipeline/expressions/AliasedAggregate.java
Show resolved
Hide resolved
...restore/src/main/java/com/google/cloud/firestore/pipeline/expressions/AliasedExpression.java
Show resolved
Hide resolved
...restore/src/main/java/com/google/cloud/firestore/pipeline/expressions/BooleanExpression.java
Show resolved
Hide resolved
...loud-firestore/src/main/java/com/google/cloud/firestore/pipeline/expressions/Expression.java
Outdated
Show resolved
Hide resolved
...cloud-firestore/src/main/java/com/google/cloud/firestore/pipeline/stages/AggregateHints.java
Outdated
Show resolved
Hide resolved
...loud-firestore/src/main/java/com/google/cloud/firestore/pipeline/stages/CollectionHints.java
Outdated
Show resolved
Hide resolved
Contributor
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
Another round of comments on the remaining files. I think we need to determine what to do with the differences in the API before release
samples/preview-snippets/src/main/java/com/example/firestore/PipelineSnippets.java
Show resolved
Hide resolved
...loud-firestore/src/main/java/com/google/cloud/firestore/pipeline/expressions/Expression.java
Outdated
Show resolved
Hide resolved
...loud-firestore/src/main/java/com/google/cloud/firestore/pipeline/expressions/Expression.java
Outdated
Show resolved
Hide resolved
wu-hui
changed the title
product-auto-label
bot
added
size: m
MarkDuckworth
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.