-
Notifications
You must be signed in to change notification settings - Fork 36
Add rss/channel/itunes:summary handling #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From above that block:
# If you modify the mapping, don't forget to also update the documentation
# section "Supported XML Elements and Attributes" in doc/index.rst
Apart from that, it's good. It might cause some feeds that have both description and itunes:summary with different content to have different results after parsing, though.
|
@thp Could we add an |
|
Just got back to this! Sorry for the delay. Yes I can look into a suitable fallback behaviour :) |
|
Here's a question, the episode description behaviour is similar to what I have suggested here so I wonder if this change-if-none behaviour should also be applied in this case. I also noted how HTML is handled in description but not in the summary according to this. Is it accurate? Should the same happen for channel/description? |
Yes. It would have the same issue, unless it already only changes if none.
It could if the RSS spec supports HTML in channel descriptions. gPodder only supports HTML descriptions for episodes and would need to detect an HTML channel description and strip it. |
|
Bump; is there anything left to do here or can this be merged? :) |
|
I'll take another pass at this next week :) |
|
I've updated this MR to include:
|
thp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super clean now, just need to remove the version bump (it's done separately as part of releasing, not in code changes in branches). Thanks!
|
Merged, thanks! |
|
Hey @thp - will there be a new release soon? I'd like to update the library in my project :) |
We noticed that some podcasts don't have descriptions but do have itunes summaries.
Here's a file that can be used in a test: http://netstorage.discovery.com/ahc/podcasts/2016/ahc-ato-podcastrss.xml