Create registration flow for Print promotion #3280
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oller. For /signin/password, /reauthenticate, /reauthenticate/password use the sign in only controller
…d cookie state is not available update a couple of e2e test assertions to work with the new passcode page
update some more of the register e2e test assertions to work with the new signin or register passcode route
amend signin controller encrypted cookie signinOrRegister state based on where the journey started
…r flow for people going through the registration journey in order for them to set consents and newsletter consents
…statements, refactor large if else block to be a series of ifs with returns to hopefully make the code more readable
…nal/immutable-data eslint rule
…at it only redirects you to the specific route you came from or the combined /signin route. This should mitigate any user enumeration attempts
akinsola-guardian
force-pushed
the
al/print-promo
branch
from
30f1f40 to
3e529ae
Compare
akinsola-guardian
changed the base branch from
main
to
rb/combine-sign-in-and-create-account
akinsola-guardian
changed the title
Base automatically changed from
rb/combine-sign-in-and-create-account
to
main
November 3, 2025 15:33
There was a problem hiding this comment.
Pull Request Overview
This PR creates a registration flow specifically for print promotion campaigns, introducing a new client ID 'printpromo' that directs users through a specialized welcome flow.
- Adds a new 'printpromo' client ID and associated routing paths
- Creates specialized welcome page and email template for print promo signups
- Implements conditional routing logic to direct print promo users to their dedicated flow
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/shared/model/Routes.ts | Adds new route paths for print promo registration and welcome flows |
| src/shared/lib/clientId.ts | Registers 'printpromo' as a valid client ID |
| src/server/routes/welcome.ts | Implements welcome/print-promo endpoint with email sending logic |
| src/server/routes/register.ts | Adds /print-promo registration endpoint and conditional routing logic |
| src/server/routes/passcode.ts | Updates passcode flow to redirect print promo users to specialized welcome page |
| src/server/lib/registrationPlatform.ts | Maps printpromo client ID to platform identification |
| src/email/templates/renderedTemplates.ts | Registers new print promo email templates |
| src/email/templates/PrintPromoSignUp/* | Creates email templates for print promo welcome emails |
| src/client/routes.tsx | Adds client-side routing for print promo pages |
| src/client/pages/WelcomePrintPromo* | Creates React components for print promo welcome page |
| src/client/pages/PasscodeUsed.tsx | Updates redirect logic for print promo users |
| cypress/integration/ete/registration_3.8.cy.ts | Adds end-to-end test for print promo registration flow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+32
to
+33
| Send us an email with subject line “REWARD” to | ||
| [email protected] to receive your reward. |
There was a problem hiding this comment.
The email address '[email protected]' is hardcoded. Consider extracting this to a configuration constant similar to how SUPPORT_EMAIL is used elsewhere in the codebase, making it easier to update and maintain.
akinsola-guardian
force-pushed
the
al/print-promo
branch
from
80d09cf to
a5ef871
Compare
…into al/print-promo
akinsola-guardian
force-pushed
the
al/print-promo
branch
from
9674b94 to
d139012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR introduces a registration flow for the Print Promotion campaign, using a new
appClientIdprintpromo.printpromovalue:appClientIdto be used identify users on the print-promo flow and to update registration platform.print-promowhich points to the Register page.welcome/print-promopage and email template for print promo signupsImages
Registration page on /print-promo/welcome/print promo for existing users/welcome/print promo for new usersEmail sent on landing on /welcome/print-promo