Add Cookie in the browser to Registration page #3287
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the "Cookies in the browser" dropdown component by extracting it into a reusable component and adding it to the Registration page. Additionally, it reinstates several eslint disable comments that were previously removed.
- Extracts the cookies disclosure UI into a new
CookiesInTheBrowsercomponent - Adds the cookies disclosure component to the Registration page
- Reinstates eslint comments for async middleware handling
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/server/lib/typedRoutes.ts | Reinstates eslint comments for async middleware in rate-limited router methods |
| src/server/lib/middleware/index.ts | Reinstates eslint comment for async middleware in request state |
| src/client/pages/SignIn.tsx | Removes inline cookies disclosure markup and replaces with new component; removes unused CSS constant |
| src/client/pages/Registration.tsx | Adds the new CookiesInTheBrowser component |
| src/client/components/CookiesInTheBrowser.tsx | Creates new reusable component containing the cookies disclosure dropdown |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import { SUPPORT_EMAIL } from '@/shared/model/Configuration'; | ||
| import { MinimalLayout } from '@/client/layouts/MinimalLayout'; | ||
| import ThemedLink from '@/client/components/ThemedLink'; | ||
| import { CookiesInTheBrowser } from '../components/CookiesInTheBrowser'; |
There was a problem hiding this comment.
Use absolute import path '@/client/components/CookiesInTheBrowser' to maintain consistency with other imports in this file.
| import { CookiesInTheBrowser } from '../components/CookiesInTheBrowser'; | |
| import { CookiesInTheBrowser } from '@/client/components/CookiesInTheBrowser'; |
| import { MinimalLayout } from '@/client/layouts/MinimalLayout'; | ||
|
|
||
| import { GatewayError } from '@/shared/model/Errors'; | ||
| import { CookiesInTheBrowser } from '../components/CookiesInTheBrowser'; |
There was a problem hiding this comment.
Use absolute import path '@/client/components/CookiesInTheBrowser' to maintain consistency with other imports in this file.
| import { CookiesInTheBrowser } from '../components/CookiesInTheBrowser'; | |
| import { CookiesInTheBrowser } from '@/client/components/CookiesInTheBrowser'; |
| import locations from '@/shared/lib/locations'; | ||
| import { SUPPORT_EMAIL } from '@/shared/model/Configuration'; | ||
| import { PasscodeErrors } from '@/shared/model/Errors'; | ||
| import { CookiesInTheBrowser } from '../components/CookiesInTheBrowser'; |
There was a problem hiding this comment.
Use absolute import path '@/client/components/CookiesInTheBrowser' to maintain consistency with other imports in this file.
| import { CookiesInTheBrowser } from '../components/CookiesInTheBrowser'; | |
| import { CookiesInTheBrowser } from '@/client/components/CookiesInTheBrowser'; |
What does this change?
Images