WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@kelvin-chappell
Copy link
Member

What is the purpose of this change?

The CI workflow introduced in #625 assumed that scalafmt was in use but it wasn't so the latest run failed.

Integrating scalafmt caused the reformatting of one file.

What is the value of this change and how do we measure success?

CI will pass and code will have consistent formatting.

@kelvin-chappell kelvin-chappell requested review from a team June 25, 2025 12:54
Copy link
Contributor

@tjsilver tjsilver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kelvin-chappell kelvin-chappell enabled auto-merge (squash) June 25, 2025 13:05
@kelvin-chappell kelvin-chappell merged commit 2e8b16a into main Jun 25, 2025
7 checks passed
@kelvin-chappell kelvin-chappell deleted the kc/scalafmt branch June 25, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants