nvfbc-sys: Add Windows Support

[ShayBox]

I have tested that nvfbc-sys and nvfbc build successfully on Linux, and that nvfbc-sys builds on Windows, however nvfbc is still incompatible with the Nvidia Capture SDK v7, I'm not sure how to go about supporting both v7 and v8, but the unsafe bindings should work, untested.

Related: #6 but still needs nvfbc support to close.

[hgaiser]

Cool, thanks for looking into this. I can't check it right now but I will later :)

…

On Sat, Mar 9, 2024, 00:49 Shayne Hartford ***@***.***> wrote: I have tested that nvfbc-sys and nvfbc build successfully on Linux, and that nvfbc-sys builds on Windows, however nvfbc is still incompatible with the Nvidia Capture SDK v7, I'm not sure how to go about supporting both v7 and v8, but the unsafe bindings *should* work, untested. ------------------------------ You can view, comment on, or merge this pull request online at: #7 Commit Summary - c10176e <c10176e> nvfbc-sys: Add Windows Support File Changes (15 files <https://github.com/hgaiser/nvfbc-rs/pull/7/files>) - *D* .editorconfig <https://github.com/hgaiser/nvfbc-rs/pull/7/files#diff-0947e2727d6bad8cd0ac4122f5314bb5b04e337393075bc4b5ef143b17fcbd5b> (8) - *M* Cargo.lock <https://github.com/hgaiser/nvfbc-rs/pull/7/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87e> (315) - *M* nvfbc-sys/Cargo.toml <https://github.com/hgaiser/nvfbc-rs/pull/7/files#diff-ccfe1899076fe454f00cdbeae7097c1fe8a9d07cfff51da0f1b288e319e79636> (5) - *D* nvfbc-sys/bindgen <https://github.com/hgaiser/nvfbc-rs/pull/7/files#diff-43c3c08c1eb671521539a8f09287c1ce29477cfe8670a85f6bb0e3ca010ae87f> (10) - *M* nvfbc-sys/build.rs <https://github.com/hgaiser/nvfbc-rs/pull/7/files#diff-44ec7a4f4cd059efafe4a83fd047068598f6682e45465a2651110459e84b8864> (75) - *D* nvfbc-sys/src/generated.rs <https://github.com/hgaiser/nvfbc-rs/pull/7/files#diff-09ea9a2233ef1027d6ddf3f91c59b176298322f54e3b9f9071c62b97e6358240> (3594) - *M* nvfbc-sys/src/lib.rs <https://github.com/hgaiser/nvfbc-rs/pull/7/files#diff-696a36a641b6bc80ca81e06c9fdbad3e7d91e6812ff19939f09000ae4b0d8148> (23) - *A* nvfbc-sys/wrapper.h <https://github.com/hgaiser/nvfbc-rs/pull/7/files#diff-57889c79c5a844f7c1762192ab332f07924f335ecb3636850912578c18b51754> (4) - *M* nvfbc/src/common.rs <https://github.com/hgaiser/nvfbc-rs/pull/7/files#diff-9243818aa5d86d48bb1c713e2459ec6bac840cfe85572082c3bfb6da4a44284e> (29) - *M* nvfbc/src/cuda.rs <https://github.com/hgaiser/nvfbc-rs/pull/7/files#diff-46b5e98d8b535aaef9d4d69948d1d50e48150a4366106e8b78e6c0a41badeecd> (55) - *M* nvfbc/src/error.rs <https://github.com/hgaiser/nvfbc-rs/pull/7/files#diff-813c9640160025b78f1b65c7553944db4b43bf97438cd9fa1845faa1b3b7250b> (37) - *M* nvfbc/src/lib.rs <https://github.com/hgaiser/nvfbc-rs/pull/7/files#diff-6eecf16f99393b8d629e6a6d94e22990a5691fd21c77940e82582aa280e38e3a> (4) - *M* nvfbc/src/system.rs <https://github.com/hgaiser/nvfbc-rs/pull/7/files#diff-ccffad16204170e7b3045095c9f14c7bb9320f78c17d20a85bef515ac5410337> (42) - *M* nvfbc/src/types.rs <https://github.com/hgaiser/nvfbc-rs/pull/7/files#diff-0e08bd83a1183f3f9bc6e48054e2c39202251fb4299f64d6683b76f4f110a50e> (9) - *M* rustfmt.toml <https://github.com/hgaiser/nvfbc-rs/pull/7/files#diff-a947c9d2523f34e53b9cdcd6411174a3148f23ea03ad8a61c1aee7b3ea005440> (2) Patch Links: - https://github.com/hgaiser/nvfbc-rs/pull/7.patch - https://github.com/hgaiser/nvfbc-rs/pull/7.diff — Reply to this email directly, view it on GitHub <#7>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFO22VZZ66KBMQ2HU2BYELYXJFALAVCNFSM6AAAAABENS7XDGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE3TMOJTGI4DCMY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[hgaiser]

Sorry for taking so long to review this. I don't think it makes sense to add Windows support if it requires quite a significant number of changes, in addition to it being officially unsupported. Any future update to the Nvidia Windows drivers might remove support for NvFBC.

[ShayBox]

I think just adding windows support to the bindings crate is enough, you can still use it unsafe without the library wrapper.

Edit: I'll revert the library changes when I get the chance.