WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Avoid overly-cautious type guards in favor of more performant type discriminators #4387

Avoid overly-cautious type guards in favor of more performant type discriminators

Avoid overly-cautious type guards in favor of more performant type discriminators #4387

Triggered via pull request December 5, 2025 04:24
Status Success
Total duration 4m 47s
Artifacts 1

ci.yml

on: pull_request
Matrix: ci
Fit to window
Zoom out
Zoom in

Annotations

1 error and 1 notice
[mobile] › playwright/integration/examples/shadow-dom.test.ts:37:7 › shadow-dom example › user can type add a new line in editor inside shadow DOM: playwright/integration/examples/shadow-dom.test.ts#L63
1) [mobile] › playwright/integration/examples/shadow-dom.test.ts:37:7 › shadow-dom example › user can type add a new line in editor inside shadow DOM Error: Timed out 8000ms waiting for expect(locator).toContainText(expected) Locator: locator('[data-cy="outer-shadow-root"]').locator('> div').getByRole('textbox') Expected string: "New line text" Received string: "This Editor is rendered within a nested Shadow DOM.Nw line text" Call log: - expect.toContainText with timeout 8000ms - waiting for locator('[data-cy="outer-shadow-root"]').locator('> div').getByRole('textbox') 12 × locator resolved to <div zindex="-1" role="textbox" translate="no" aria-multiline="true" contenteditable="true" data-slate-node="value" data-slate-editor="true">…</div> - unexpected value "This Editor is rendered within a nested Shadow DOM.Nw line text" 61 | expect(pageErrors, 'Page errors occurred').toEqual([]) 62 | > 63 | await expect(textbox).toContainText('New line text') | ^ 64 | }) 65 | }) 66 | at /home/runner/work/slate/slate/playwright/integration/examples/shadow-dom.test.ts:63:27
🎭 Playwright Run Summary
1 flaky [mobile] › playwright/integration/examples/shadow-dom.test.ts:37:7 › shadow-dom example › user can type add a new line in editor inside shadow DOM 3 skipped 119 passed (2.7m)

Artifacts

Produced during runtime
Name Size Digest
test-results
418 KB
sha256:852f41450898f90101f112cac2c5bc6414cfe1a95dddcd29382d6c305efbee13