WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

fix: Prevent domSelection.collapseToEnd crash in setDomSelection #5752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leondt1 wants to merge 3 commits into from
Closed

fix: Prevent domSelection.collapseToEnd crash in setDomSelection #5752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c01d54
fix: Prevent domSelection.collapseToEnd crash in setDomSelection
leondt1 Oct 28, 2024
e54a0f1
Create healthy-lizards-clap.md
leondt1 Oct 28, 2024
5b25ed9
fix: fix eslint problem
leondt1 Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-lizards-clap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"slate-react": patch
---

fix: Prevent domSelection.collapseToEnd crash in setDomSelection
6 changes: 5 additions & 1 deletion packages/slate-react/src/components/editable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,11 @@ export const Editable = forwardRef(
selection && ReactEditor.toDOMRange(editor, selection)

if (newDomRange) {
if (ReactEditor.isComposing(editor) && !IS_ANDROID) {
if (
ReactEditor.isComposing(editor) &&
hasDomSelection &&
!IS_ANDROID
) {
domSelection.collapseToEnd()
} else if (Range.isBackward(selection!)) {
domSelection.setBaseAndExtent(
Expand Down
Loading