Scroll to focus point of expanded selections #5968
Merged
+59
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
defaultScrollSelectionIntoViewonly scrolls collapsed selections into view, citing the following concern:slate/packages/slate-react/src/components/editable.tsx
Lines 1954 to 1955 in c6137cd
This causes a bug when undoing the deletion of a range of text. To reproduce:
Bug_screen_capture.mp4
This PR updates
defaultScrollSelectionIntoViewto allow scrolling when the selection is expanded, but it specifically scrolls to the focus point of the selection (rather than trying to scroll to the entire selected range). This fixes the undo-after-delete bug:Fix_screen_capture.mp4
And scrolling to the focus point appears to avoid the issues with "the selection of multiple blocks and dragging behavior" that the original comment mentions. I've experienced those issues in development when allowing scrolling to expanded selections if I'm still trying to scroll to the entire
domRange. But we've made thisdomFocusPointchange in our project's customscrollSelectionIntoView, and I can't find any undesired behaviors when creating large selections, using either the mouse or the keyboard.Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)