WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@nabbydude
Copy link
Contributor

Description
After #5871, the only usage of immer left is in Node.fragment for creating a fragment object. This PR switches it to using the existing non-immer functions.

Issue
Mainly decreases bundle size for the slate package
Fixes #5644 by circumvention, could affect a solution posted for #4111

Context
I couldn't find any actual unit tests for fragments, but manual testing has yielded identical results. If I have the time and patience I might add some next week

also this removes tiny-warning which was entirely unused already

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2025

🦋 Changeset detected

Latest commit: 27e9fee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess immer is not really always. 😂

This looks fine to me, going to land another fix to hopefully clean up the failing tests.

@dylans dylans merged commit addf0c5 into ianstormtaylor:main Nov 21, 2025
11 checks passed
This was referenced Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to immer@10+ breaks react native + hermes builds

2 participants