IBX-10233: Fixed iterating over a batch of files in ibexa:io:migrate-files command
#661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the file migration command where the migration process would terminate prematurely if an entire batch of files was missing. The fix changes the loop termination condition from checking if the current batch has files to verifying if there are more files to process based on the total file count.
Key Changes:
- Store the total file count before starting the migration loop
- Calculate offset explicitly for better readability
- Replace batch-based loop condition with offset-based condition that checks against total file count
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ibexa-workflow-automation-1
bot
requested review from
Steveb-p,
ViniTou,
adamwojs,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
konradoboza
approved these changes
Dec 2, 2025
alongosz
changed the title
ibexa:io:migrate-files command
alongosz
approved these changes
Dec 3, 2025
…g (ibexa:io:migrate-files)
tomaszszopinski
force-pushed
the
IBX-10233_File_migration_fails_when_a_whole_batch_of_files_is_missing
branch
from
b8caedf to
e0d806a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If all files in the current bulk are missing, then
$metadataList($metadataList = $fileLister->loadMetadataList($bulkCount, $offset);) will be a empty list. This will cause the loop to be exited prematurely (while (count($metadataList) > 0))For QA:
Documentation: