WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@mweststrate
Copy link
Collaborator

@mweststrate mweststrate commented Mar 11, 2024

  • [x]: fix tests. Maybe introduce additional flag as this might be dangerous for classes.
  • [x]: can we optimize each / finalize based on the same setting? See Faster iteration experiment #1120
  • [x]: make a tristate flag? !strict is very unsafe for classes

@coveralls
Copy link

coveralls commented Mar 11, 2024

Pull Request Test Coverage Report for Build 8862180750

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.794%

Totals Coverage Status
Change from base Build 8861675542: 0.001%
Covered Lines: 649
Relevant Lines: 650

💛 - Coveralls

@mweststrate mweststrate merged commit 53e3203 into main Apr 27, 2024
@github-actions
Copy link
Contributor

🎉 This PR is included in version 10.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants