Remove unused variables #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
On Gitlab for CI: https://gitlab.tiker.net/inducer/pycuda/-/commits/richard |
Owner
|
Thanks for the patch! I'd be supportive of adding those flags. It might be good to switch over to scikit-build at the same time (since setuptools will eventually stop being a thing) to avoid duplication of effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Meta we have
-Wunused-variableand-Wunused-const-variableenabled for clang across our entire codebase. It'd be swell if PyCuda were able to enable similar warnings to prevent this kind of cruft from building up. I'm not sure what the most appropriate way to do that is, though.Thanks for your good work!