WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@vlerdman
Copy link
Contributor

This PR adds tracking total size of nodes during graph walk. New code saves backward compability with ipfs/kubo.

Changes

  • Extend merkledag.ProgressTracker to save and update TotalSize of visited nodes
  • Update progress via wrapping GetLinksDirect function instead of visit
  • Update testProgressIndicator for checking TotalSize

References

@vlerdman vlerdman requested a review from a team as a code owner November 23, 2025 13:10
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vlerdman thank you for submitting this – any chance you could also:

  • open a PR in https://github.com/ipfs/kubo that uses this in ipfs pin add command and has green CI there as well
    ? (it would speed up review process)

@vlerdman
Copy link
Contributor Author

vlerdman commented Nov 24, 2025

@vlerdman thank you for submitting this – any chance you could also:

  • open a PR in https://github.com/ipfs/kubo that uses this in ipfs pin add command and has green CI there as well
    ? (it would speed up review process)

@lidel Thanks for such fast feedback! Opened a PR - ipfs/kubo#11074

@hsanjuan
Copy link
Contributor

Triage:

  • Will be reviewed and probably going into 0.40.

@gammazero gammazero self-requested a review December 2, 2025 15:33
@gammazero gammazero merged commit 0842ad2 into ipfs:main Dec 2, 2025
11 checks passed
gammazero added a commit to vlerdman/kubo that referenced this pull request Dec 2, 2025
gammazero pushed a commit to ipfs/kubo that referenced this pull request Dec 3, 2025
* Add bytes progress tracker for ipfs pin add
* upgrade to boxo that has ipfs/boxo#1071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add total size of pinned objects to pin add progress reports.

4 participants