-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix istio proxy build after moving Envoy to hermteic toolchain #6726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Mikhail Krinkin <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
😊 Welcome @krinkinmu! This is either your first contribution to the Istio proxy repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
/test all |
howardjohn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean you can finally just run bazel build and it works??? amazing!!
Almost, but there are corner cases. E.g., llvm tools themselves are not built statically, so they still depend on some external libraries, but at the very least installing clang should not be necessary. And we still need to figure out if we want to go this way or rely on a local toolchain. |
.bazelrc
Outdated
| # ======================================== | ||
|
|
||
| # Enable libc++ and C++20 by default. | ||
| build:linux --config=clang-local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change this to --config=clang and give another try?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested locally and it works, now will try on CI.
Signed-off-by: Mikhail Krinkin <[email protected]>
|
/test all |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: