Add workaround for Gem::Package::TarWriter#add_file
#378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unasuke
force-pushed
the
workaround-for-tarwriter
branch
2 times, most recently
from
d622ed7 to
cd82928
Compare
Merged
Member
|
@unasuke How is the progress on this patch? Since next ruby minor or major version will be released soon (probably 2025/12/2x), I hope we can merge it before then. |
Member
Author
|
@sue445 Sorry, I forgot it. I'll revise it. |
unasuke
force-pushed
the
workaround-for-tarwriter
branch
2 times, most recently
from
089230f to
2f45e69
Compare
From rubygems v3.6.7, `Gem::Package::TarWriter#add_file` uses `SOURCE_DATE_EPOCH` env var to set file mtime. This is a workaround for Docker backend where `Gem::Package::TarWriter#add_file` used in Docker backend. See also: * ruby/rubygems#8673 * #377 * #378
unasuke
force-pushed
the
workaround-for-tarwriter
branch
from
2f45e69 to
42d9220
Compare
unasuke
changed the title
unasuke
changed the title
Gem::Package::TarWriter#add_file
This reverts commit 3a5a55b.
Member
Author
|
@sue445 ALL GREEN 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
From rubygems v3.6.7,
Gem::Package::TarWriter#add_fileusesSOURCE_DATE_EPOCHenv var to set file mtime.This is a workaround for Docker backend where
Gem::Package::TarWriter#add_fileused in Docker backend.See also: