WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@AndreiDinca24
Copy link
Collaborator

@AndreiDinca24 AndreiDinca24 commented Nov 19, 2025

Added support for package signing.

Passing tests: ProjectPack and SolutionPack

Are there any breaking changes?

  • None
  • Input parameter renaming/removal
  • New input parameter that changes the previous default behaviour
  • Authentication option removal
  • Changing the default CLI that come with breaking changes compared to the previous default CLI version

@AndreiDinca24 AndreiDinca24 force-pushed the task/STUD-78152-support-pack-signing branch 2 times, most recently from 3bf2a46 to 37d9482 Compare November 26, 2025 09:57
@AndreiDinca24 AndreiDinca24 marked this pull request as ready for review November 26, 2025 09:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for package signing to the Jenkins UiPath plugin, implementing the ability to sign packages with digital certificates during the packaging process.

Key Changes

  • Added certificate-based package signing functionality with support for certificate path, password, and timestamp server URL
  • Reorganized UI with a new "More Settings" collapsible section to group advanced options
  • Added UiPath branding header to the Solution Pack configuration UI

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
src/main/java/com/uipath/uipathpackage/solutions/UiPathSolutionPack.java Added package signing implementation with certificate credential handling
src/main/java/com/uipath/uipathpackage/UiPathPack.java Added package signing support (with some code quality issues in imports)
src/main/java/com/uipath/uipathpackage/models/solutions/SolutionPackOptions.java Added certificate fields to options model
src/main/java/com/uipath/uipathpackage/models/PackOptions.java Added certificate fields to options model
src/main/resources/com/uipath/uipathpackage/solutions/UiPathSolutionPack/config.jelly Added UI header with branding and package signing UI fields
src/main/resources/com/uipath/uipathpackage/UiPathPack/config.jelly Added package signing UI fields within More Settings section
src/main/resources/com/uipath/uipathpackage/solutions/UiPathSolutionPack/config*.properties Added localization keys (empty in non-English locales)
src/main/resources/com/uipath/uipathpackage/UiPathPack/config.properties Missing localization keys for package signing options
CODEOWNERS Fixed formatting (added missing * prefix)
pom.xml Added property to disable JUnit4 import ban

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AndreiDinca24 AndreiDinca24 force-pushed the task/STUD-78152-support-pack-signing branch from 37d9482 to c21651a Compare November 26, 2025 12:24
@AndreiDinca24 AndreiDinca24 force-pushed the task/STUD-78152-support-pack-signing branch from c21651a to 2fc5c54 Compare November 26, 2025 12:44
@AndreiDinca24 AndreiDinca24 merged commit 597fd50 into jenkinsci:develop Nov 27, 2025
13 checks passed
@AndreiDinca24 AndreiDinca24 deleted the task/STUD-78152-support-pack-signing branch November 27, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants