-
Notifications
You must be signed in to change notification settings - Fork 30
Jenkins: support pack signing [STUD-78152] #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkins: support pack signing [STUD-78152] #211
Conversation
src/main/java/com/uipath/uipathpackage/models/solutions/SolutionPackOptions.java
Fixed
Show fixed
Hide fixed
src/main/java/com/uipath/uipathpackage/solutions/UiPathSolutionPack.java
Fixed
Show fixed
Hide fixed
src/main/java/com/uipath/uipathpackage/solutions/UiPathSolutionPack.java
Dismissed
Show dismissed
Hide dismissed
3bf2a46 to
37d9482
Compare
src/main/java/com/uipath/uipathpackage/models/PackOptions.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/com/uipath/uipathpackage/models/solutions/SolutionPackOptions.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/com/uipath/uipathpackage/solutions/UiPathSolutionPack.java
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds support for package signing to the Jenkins UiPath plugin, implementing the ability to sign packages with digital certificates during the packaging process.
Key Changes
- Added certificate-based package signing functionality with support for certificate path, password, and timestamp server URL
- Reorganized UI with a new "More Settings" collapsible section to group advanced options
- Added UiPath branding header to the Solution Pack configuration UI
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/java/com/uipath/uipathpackage/solutions/UiPathSolutionPack.java |
Added package signing implementation with certificate credential handling |
src/main/java/com/uipath/uipathpackage/UiPathPack.java |
Added package signing support (with some code quality issues in imports) |
src/main/java/com/uipath/uipathpackage/models/solutions/SolutionPackOptions.java |
Added certificate fields to options model |
src/main/java/com/uipath/uipathpackage/models/PackOptions.java |
Added certificate fields to options model |
src/main/resources/com/uipath/uipathpackage/solutions/UiPathSolutionPack/config.jelly |
Added UI header with branding and package signing UI fields |
src/main/resources/com/uipath/uipathpackage/UiPathPack/config.jelly |
Added package signing UI fields within More Settings section |
src/main/resources/com/uipath/uipathpackage/solutions/UiPathSolutionPack/config*.properties |
Added localization keys (empty in non-English locales) |
src/main/resources/com/uipath/uipathpackage/UiPathPack/config.properties |
Missing localization keys for package signing options |
CODEOWNERS |
Fixed formatting (added missing * prefix) |
pom.xml |
Added property to disable JUnit4 import ban |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...main/resources/com/uipath/uipathpackage/solutions/UiPathSolutionPack/config_es-MX.properties
Show resolved
Hide resolved
src/main/resources/com/uipath/uipathpackage/solutions/UiPathSolutionPack/config_de.properties
Show resolved
Hide resolved
src/main/resources/com/uipath/uipathpackage/solutions/UiPathSolutionPack/config_tr.properties
Show resolved
Hide resolved
src/main/resources/com/uipath/uipathpackage/solutions/UiPathSolutionPack/config_ru.properties
Show resolved
Hide resolved
...main/resources/com/uipath/uipathpackage/solutions/UiPathSolutionPack/config_zh-CN.properties
Show resolved
Hide resolved
src/main/resources/com/uipath/uipathpackage/solutions/UiPathSolutionPack/config_pt.properties
Show resolved
Hide resolved
...main/resources/com/uipath/uipathpackage/solutions/UiPathSolutionPack/config_pt-BR.properties
Show resolved
Hide resolved
src/main/resources/com/uipath/uipathpackage/solutions/UiPathSolutionPack/config_ko.properties
Show resolved
Hide resolved
src/main/resources/com/uipath/uipathpackage/solutions/UiPathSolutionPack/config_ja.properties
Show resolved
Hide resolved
37d9482 to
c21651a
Compare
c21651a to
2fc5c54
Compare
Added support for package signing.
Passing tests: ProjectPack and SolutionPack
Are there any breaking changes?