Fix prefix sort complexity #1664
Merged
+278
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation doesn't scale well and can lead to high CPU use
vlad-ivanov-name
force-pushed
the
vlad/fix-prefix-sort-complexity
branch
from
3bbf825 to
d6ed9e8
Compare
Member
christian-schilling
left a comment
christian-schilling
left a comment
There was a problem hiding this comment.
This is becoming so much code. Maybe split out to seperate file?
Otherwise lgtm.
Long term I'm wondering if we really need to sort at all..but for now this looks like a good fix.
christian-schilling
approved these changes
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation doesn't scale well and can lead to high CPU use