feat(platform): implement payment method sharing model for platform-connected setup #10458

tsdk02 · 2025-11-27T19:33:28Z

Type of Change

Description

This PR introduces provider context support for Payment Methods, extending the platform-connected model that already exists for customers. The objective is to ensure that payment methods are consistently treated as platform-owned resources, while still allowing connected merchants within the same organization to access and use them.

Key Changes

1. Provider Context for Payment Methods

Payment methods are now associated with the provider merchant (Platform) rather than the connected merchant that performs the operation.
All connected merchants under the same platform organization can access the shared pool of payment methods.
Eliminates duplicated payment methods across connected merchants.
Platform merchants can operate:
- With X-Connected-Merchant-Id header (acting on behalf of a connected merchant).
- Without the header (acting as the platform itself).

2. Provider / Processor Role Separation

Provider (Platform Merchant) owns shared resources such as payment methods and customers.
Processor (Connected or Platform Merchant) is used only for transaction processing.
This PR ensures payment method operations consistently use provider context, without altering processor-related behavior.

3. Updated Payment Method Endpoints

All v1/v2 CRUD endpoints and attach/detach routes now resolve provider context before executing business logic.
Authentication flags for v1 payment method endpoints updated to:

is_connected_allowed: true
is_platform_allowed: true

Removed legacy assumptions where payment methods were tied to the processor merchant.

4. Core Refactoring

Updated domain models and validation logic to carry provider-related fields.
Centralized provider context resolution for all payment method operations.

5. Webhook and Compatibility Adjustments

Incoming webhook handlers updated to resolve provider context consistently.
Stripe compatibility layer updated to support platform-owned payment methods.
Ensures webhook-originated updates operate under the provider model.

Scope Clarification (Important)

This PR does not include:

Account-PML filtering based on processor merchant capabilities
Customer-PML filtering based on supported payment methods
SDK changes for sending connected merchant context
3DS or callback-based connected context handling

These enhancements will be implemented in follow-up PRs.

Motivation and Context

Problems Addressed

Payment methods were owned by individual connected merchants, causing duplication and fragmentation.
Provider context was inconsistently handled across payment method operations.
Platform merchants lacked proper visibility and operational consistency.
Payment method behavior did not match the customer-sharing model already in place.

Solution Summary

Introduced provider-context ownership for payment methods.
Centralized and unified provider context resolution across all payment method operations.
Enabled connected merchants to access shared platform-owned payment methods.
Aligned payment methods with the customer-sharing model for consistency across the platform organization.

APIs Affected

POST /payment_methods (v1, v2)
GET /payment_methods/:id (v1, v2)
GET /payment_methods (list) (v1, v2)
PATCH /payment_methods/:id (v1, v2)
DELETE /payment_methods/:id (v1, v2)
Attach/Detach operations
Tokenization flows involving payment method ownership

Diagram: Current (Incorrect) Merchant-Scoped Model

Diagram: Proposed Platform-Scoped Model

How did you test it?

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

…onality This change introduces provider context support throughout the payment methods module, enabling better handling of provider-specific configurations and enhancing the flexibility of payment method operations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

semanticdiff-com · 2025-11-27T19:33:30Z

Review changes with

Changed Files

File	Status
crates/router/src/core/payouts/helpers.rs	99% smaller
crates/router/src/core/payments/tokenization.rs	96% smaller
crates/router/src/core/payments/payment_methods.rs	96% smaller
crates/router/src/core/webhooks/network_tokenization_incoming.rs	90% smaller
crates/router/src/routes/payment_methods.rs	65% smaller
crates/router/src/core/customers.rs	58% smaller
crates/payment_methods/src/core/migration/payment_methods.rs	56% smaller
crates/router/src/types/api/mandates.rs	38% smaller
crates/router/src/core/payment_methods/cards.rs	36% smaller
crates/router/src/core/payment_methods.rs	18% smaller
crates/router/src/core/payment_methods/tokenize/card_executor.rs	11% smaller
crates/router/src/core/locker_migration.rs	4% smaller
crates/router/src/compatibility/stripe/customers.rs	0% smaller
crates/router/src/core/payment_methods/migration.rs	0% smaller
crates/router/src/core/payment_methods/network_tokenization.rs	0% smaller
crates/router/src/core/payment_methods/tokenize.rs	0% smaller
crates/router/src/core/payment_methods/validator.rs	0% smaller
crates/router/src/core/payment_methods/vault.rs	0% smaller
crates/router/src/core/payouts/validator.rs	0% smaller
crates/router/src/core/webhooks/incoming.rs	0% smaller
crates/router/src/routes/customers.rs	0% smaller

codecov · 2025-11-27T19:53:27Z

Codecov Report

❌ Patch coverage is 0% with 95 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@8e33f24). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
crates/router/src/core/payment_methods.rs	0.00%	37 Missing ⚠️
crates/router/src/routes/payment_methods.rs	0.00%	35 Missing ⚠️
crates/router/src/core/customers.rs	0.00%	8 Missing ⚠️
crates/router/src/core/payments/payment_methods.rs	0.00%	6 Missing ⚠️
crates/router/src/core/payment_methods/cards.rs	0.00%	5 Missing ⚠️
crates/router/src/routes/customers.rs	0.00%	2 Missing ⚠️
...ment_methods/src/core/migration/payment_methods.rs	0.00%	1 Missing ⚠️
crates/router/src/core/payment_methods/vault.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10458   +/-   ##
=======================================
  Coverage        ?    6.46%           
=======================================
  Files           ?     1251           
  Lines           ?   311788           
  Branches        ?        0           
=======================================
  Hits            ?    20164           
  Misses          ?   291624           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

apoorvdixit88

We can consider making wrapper wherever we are making direct db call with platform.

apoorvdixit88 · 2025-12-01T11:12:58Z

crates/router/src/core/payment_methods/migration.rs

    let mut updated_card_expiry = false;

    let payment_method = db
        .find_payment_method(


Here we can consider making the wrapper, i think its already there in the get_tracker PR, we can use the same.

Will take this up in a separate PR, once the wrapper setup is finalized

apoorvdixit88 · 2025-12-01T11:13:30Z

crates/router/src/core/payment_methods/migration.rs

    let response = db
        .update_payment_method(
-            platform.get_processor().get_key_store(),
+            platform.get_provider().get_key_store(),


here as well we can consider making platform wrapper.

Will take this up in a separate PR, once the wrapper setup is finalized

…_method API

jarnura · 2025-12-03T08:49:43Z

crates/router/src/core/payment_methods/migration.rs

    let mut updated_card_expiry = false;

    let payment_method = db
        .find_payment_method(


jarnura · 2025-12-03T08:49:51Z

crates/router/src/core/payment_methods/migration.rs

    let response = db
        .update_payment_method(
-            platform.get_processor().get_key_store(),
+            platform.get_provider().get_key_store(),


apoorvdixit88 · 2025-12-04T19:29:40Z

crates/router/src/core/payments/helpers.rs


            #[cfg(feature = "v1")]
            let payment_intent = db
                .find_payment_intent_by_payment_id_merchant_id(


Wrapper needed, and we need to check working of this function, in this flow

Modified this to use processor, queries also need to be changed later to query on processor_merchant_id.

Wrappers will be added in a subsequent PR.

apoorvdixit88 · 2025-12-04T19:31:57Z

crates/router/src/core/payouts/helpers.rs

+                customer_id,
+                &payment_method_id,
+                Some(stored_resp.card_reference.clone()),
+                platform.get_processor().get_account().get_id(),


won't it be provider?

Yes, it should be. But this change was done only to remove the error as I had changed platform to provider in PmCards struct.

I haven't touched this flow yet, as it comes under payouts.
Will modify this in a separate PR when working on adding the provider context in payouts.

tsdk02 requested review from a team as code owners November 27, 2025 19:33

tsdk02 self-assigned this Nov 27, 2025

tsdk02 added A-core Area: Core flows T-Core For Work done by the core team platform labels Nov 27, 2025

chore: fixed clippy v2 errors

51bf49a

tsdk02 changed the title ~~feat(platform): Add provider context to payment methods~~ feat(platform): implement payment method sharing model for platform-connected setup Nov 28, 2025

Merge branch 'main' into provider-context-in-payment-methods

71e0569

apoorvdixit88 reviewed Dec 1, 2025

View reviewed changes

tsdk02 and others added 4 commits December 1, 2025 18:24

feat: added provider context in remaining v2 APIs

5a9cc9a

feat: allow platform and connected merchants to access create_payment…

b300ec5

…_method API

Merge branch 'main' into provider-context-in-payment-methods

e2d6b30

chore: run formatter

192b1bf

jarnura previously approved these changes Dec 3, 2025

View reviewed changes

Sakilmostak previously approved these changes Dec 3, 2025

View reviewed changes

ShankarSinghC previously approved these changes Dec 3, 2025

View reviewed changes

apoorvdixit88 reviewed Dec 4, 2025

View reviewed changes

prasunna09 previously approved these changes Dec 5, 2025

View reviewed changes

chore: addressed comments

5231ff5

tsdk02 dismissed stale reviews from prasunna09, ShankarSinghC, Sakilmostak, and jarnura via 5231ff5 December 5, 2025 11:03

feat(platform): implement payment method sharing model for platform-connected setup #10458

Are you sure you want to change the base?

feat(platform): implement payment method sharing model for platform-connected setup #10458

Conversation

tsdk02 commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

Key Changes

1. Provider Context for Payment Methods

2. Provider / Processor Role Separation

3. Updated Payment Method Endpoints

4. Core Refactoring

5. Webhook and Compatibility Adjustments

Scope Clarification (Important)

Motivation and Context

Problems Addressed

Solution Summary

APIs Affected

Diagram: Current (Incorrect) Merchant-Scoped Model

Diagram: Proposed Platform-Scoped Model

How did you test it?

Checklist

Uh oh!

semanticdiff-com bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

apoorvdixit88 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

apoorvdixit88 Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tsdk02 Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tsdk02 commented Nov 27, 2025 •

edited

Loading

semanticdiff-com bot commented Nov 27, 2025 •

edited

Loading

codecov bot commented Nov 27, 2025 •

edited

Loading

apoorvdixit88 Dec 4, 2025 •

edited

Loading

tsdk02 Dec 4, 2025 •

edited

Loading