-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(platform): support payment create get tracker for platform #10465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10465 +/- ##
=======================================
Coverage ? 6.46%
=======================================
Files ? 1254
Lines ? 311989
Branches ? 0
=======================================
Hits ? 20161
Misses ? 291828
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crates/router/src/platform_wrapper/merchant_connector_account.rs
Outdated
Show resolved
Hide resolved
crates/router/src/platform_wrapper/merchant_connector_account.rs
Outdated
Show resolved
Hide resolved
| ) -> errors::CustomResult<Profile, errors::StorageError> { | ||
| db.find_business_profile_by_profile_id(processor.get_key_store(), profile_id) | ||
| .await | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have an interface instead of dangling function
ShankarSinghC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of Change
Description
This PR adds the basic Platform-aware wiring for the payment create → get tracker flow. It is not the complete Platform payments feature — the goal is only to make the existing path work correctly when a Platform triggers a payment for a connected merchant as well as for a standard merchant.
To clarify the current behaviour with the Platform model introduced in this PR:
Key changes:
This sets the foundation for the full Platform behaviour to be completed in later PRs.
Additional Changes
Motivation and Context
Closes #10488
How did you test it?
This can be tested for platform feature once the whole payment_create flow is done.
Checklist
cargo +nightly fmt --allcargo clippy